My favorite NHibernate exception

lol, I just incurred in the same mistake! My problem now is to fix things like this:

public virtual int Id

{

get {return _id;}

internal set {_id = value;} // wrong must be protected virtual

}

Oh yes, ditto here. Guess this is a case when "RTFM!!111" is so important.

I could have been in a dream, but I vaguely remember reading a post where Ayende actually said NHibernate didn't require virtual methods anymore and he just hasn't gone in and removed the check yet.

Totally agreed, that exception is really irritating.

“Virtual by default” has nothing about testability, probably if you have to put your objects in "not expected" state (by overriding parts of the object) you are wasting time on testing syntetic or impossible stuff. This actually the same antipattern as testing private methods with reflection.

Regarding "false assumption", well, so your point of view is not to think at all? Overridability is some sor of the selfdocumentaiton, means that when you have code with all overridable members, you do not know where to extend it.

Hope this makes sence.

I'm still a bit torn over virtual by default - many methods almost never make sense to override.

What I would like though is a class keyword to make all members of that single class virtual :-)

You can actually turn off the "virtual by default" option in the NHibernate source code. I had to do this once before, it is in the central configuration class. Sorry I cant remember the actual name of this class of the top of my head, but there is a main configuration class that holds all kinds of interesting default settings!